View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001589T99X171.00 SKB EagleSW Issuepublic2022-12-27 12:212024-04-19 14:12
Reporter(ALTech) Younkwang Jung Assigned To(ALTech) Younkwang Jung Due Date
PrioritynormalSeveritys4-minorReproducibilityalways
Status closedResolutionfixed 
Summary0001589: [Smart3][ATV10] edid parsing issue at LG TV (LG TV SSCR2)
DescriptionHi Kerwin

An issue where the full model_name of LG TV is not displayed was observed
https://jira.skbroadband.com/browse/BTFAML-1352

First of all, the primary issue seems to be the issue of Amlogic's parsing syntax
However, even if I modify it, hdmi-edid.xml still does not display the full model name

[current status] please check attached files (current_amhdmitx0_edid.txt/current_hdmi-edid.txt)
cat /sys/class/amhdmitx/amhdmitx0/edid
..
Rx Product Name: LG
..

cat /btv_home/tmp/hdmi-edid.xml
..
model_name="LG"
..


[After applying the test patch BTFAML-1352 ] please check attached files (hdmi-edid_after_apply_test_patch.txt/amhdmitx0_edid_after_apply_test_patch.txt)
cat /sys/class/amhdmitx/amhdmitx0/edid
..
Rx Product Name: LG TV SSCR2 <== it's ok
..

cat /btv_home/tmp/hdmi-edid.xml
..
model_name="LG" <= there is still a problem.
..

Please check the two below.
1) Please check if it is okay to apply the test patch provided by SKB
2) Please check the issue that model_name cannot be changed in hdmi-edid.xml even after applying SKB patch.

Thank you
YK.Jung
TagsNo tags attached.
Attach Tags

Users monitoring this issue

User List (ALTech) JunGyu Kim , (ALTech) SY Yoon

Activities

(ALTech) Younkwang Jung

2022-12-27 12:21

developer  

hdmi-edid_after_apply_test_patch.txt (3,044 bytes)    
BFX-AT100:/ # cat /btv_home/tmp/hdmi-edid.xml
<?xml version='1.0' encoding='UTF-8' standalone='yes' ?>
<hdmi_edid hotplug="1" edid_version="1.3" model_name="LG" manufacturer_id="GSM" product_code="c0c8" serial_number="01010101" manufacture_date="1/2022">
<edid_hex>
0011ffffffffff001e6dc8c001010101
0120010380a05a780aee91a3544c9926
0f5054a1080031404540614071408180
d1c00101010108e80030f2705a80b058
8a0040846300001e6fc200a0a0a05550
3020350040846300001e000000fd0018
781eff77000a202020202020000000fc
004c472054562053534352320a200164
020366f15d616076756665dbda101f04
130514030212202122155d5e5f626364
3f402c0957071507505707016704036e
030c001000b8442c0080010203046dd8
5dc40178806b022878c33305e200cfe3
05c000e3060d01e20fffeb0146d00048
0a7e8660769400000000000000000000
000000000000000000000000000000f7
</edid_hex>
<supported_Video>
<video resolution="720x576i" Hz="50Hz" />
<video resolution="720x480p" Hz="60Hz" />
<video resolution="720x576p" Hz="50Hz" />
<video resolution="1280x720p" Hz="60Hz" />
<video resolution="1920x1080i" Hz="60Hz" />
<video resolution="1920x1080p" Hz="60Hz" />
<video resolution="1920x1080p" Hz="120Hz" />
<video resolution="1280x720p" Hz="50Hz" />
<video resolution="1920x1080i" Hz="50Hz" />
<video resolution="1920x1080p" Hz="30Hz" />
<video resolution="1920x1080p" Hz="50Hz" />
<video resolution="1920x1080p" Hz="25Hz" />
<video resolution="1920x1080p" Hz="24Hz" />
<video resolution="3840x2160p" Hz="30Hz" />
<video resolution="3840x2160p" Hz="25Hz" />
<video resolution="3840x2160p" Hz="24Hz" />
<video resolution="4096x2160p" Hz="24Hz" />
<video resolution="4096x2160p" Hz="25Hz" />
<video resolution="4096x2160p" Hz="30Hz" />
<video resolution="4096x2160p" Hz="50Hz" />
<video resolution="4096x2160p" Hz="60Hz" />
<video resolution="3840x2160p" Hz="50Hz" />
<video resolution="3840x2160p" Hz="60Hz" />
<video resolution="640x480p" Hz="60Hz" />
<video resolution="800x600p" Hz="60Hz" />
<video resolution="1024x768p" Hz="60Hz" />
<video resolution="1280x1024p" Hz="60Hz" />
</supported_Video>
<supported_420Video>
</supported_420Video>
<preferred_Video>
<video resolution="(null)" />
</preferred_Video>
<supported_Audio>
<audio codec="LPCM" ch="2" SamplingRate="32^44.1^48^96^192" />
<audio codec="AC3" ch="6" SamplingRate="32^44.1^48" />
<audio codec="DD+" ch="8" SamplingRate="32^44.1^48" />
<audio codec="Dolby TrueHD" ch="8" SamplingRate="48" />
</supported_Audio>
<supported_Color>
<color sampling="YCrCb 4:2:0" depth="6" />
<color sampling="YCrCb 4:2:0" depth="5" />
<color sampling="YCrCb 4:2:0" depth="4" />
<color sampling="YCrCb 4:4:4" depth="6" />
<color sampling="YCrCb 4:4:4" depth="5" />
<color sampling="YCrCb 4:4:4" depth="4" />
<color sampling="YCrCb 4:2:2" depth="6" />
<color sampling="YCrCb 4:2:2" depth="5" />
<color sampling="YCrCb 4:2:2" depth="4" />
<color sampling="RGB 4:4:4" depth="6" />
<color sampling="RGB 4:4:4" depth="5" />
<color sampling="RGB 4:4:4" depth="4" />
</supported_Color>
</hdmi_edid>
BFX-AT100:/ #
amhdmitx0_edid_after_apply_test_patch.txt (985 bytes)    
BFX-AT100:/ # cat /sys/class/amhdmitx/amhdmitx0/edid
Rx Manufacturer Name: GSM
Rx Product Code: c0c8
Rx Serial Number: 01010101
Rx Product Name: LG TV SSCR2

Manufacture Week: 1
Manufacture Year: 2022
Physcial size(cm): 160 x 90
EDID Version: 1.3
EDID block number: 0x1
blk0 chksum: 0x64
Source Physical Address[a.b.c.d]: 1.0.0.0
native Mode f1, VIC (native 97):
ColorDeepSupport b8
97 96 118 117 102 101 219 218 16 31 4 19 5 20 3 2 18 32 33 34 21 93 94 95 98 99 100 63 64 95 94 93 98 353 352 358 357
Audio {format, channel, freq, cce}
{1, 1, 57, 7}
{2, 5, 7, 50}
{10, 7, 7, 1}
{12, 7, 4, 3}
Speaker Allocation: 0
Vendor: 0xc03 ( HDMI device)
MaxTMDSClock1 340 MHz
Vendor2: 0xc45dd8
MaxTMDSClock2 600 MHz
ALLM: 1
vLatency:  Invalid/Unknown
aLatency:  Invalid/Unknown
i_vLatency:  Invalid/Unknown
i_aLatency:  Invalid/Unknown
ColorMetry: 0xc0
SCDC: 1
RR_Cap: 0
LTE_340M_Scramble: 0
  DolbyVision2  HDR  DeepColor
checkvalue: 0x64f70000
BFX-AT100:/ #
current_hdmi-edid.txt (3,384 bytes)    
BFX-AT100:/btv_home/tmp # cat hdmi-edid.xml
<?xml version='1.0' encoding='UTF-8' standalone='yes' ?>
<hdmi_edid hotplug="1" edid_version="1.3" model_name="LG" manufacturer_id="GSM" product_code="c0c8" serial_number="01010101" manufacture_date="1/2022">
<edid_hex>
0011ffffffffff001e6dc8c001010101
0120010380a05a780aee91a3544c9926
0f5054a1080031404540614071408180
d1c00101010108e80030f2705a80b058
8a0040846300001e6fc200a0a0a05550
3020350040846300001e000000fd0018
781eff77000a202020202020000000fc
004c472054562053534352320a200164
020366f15d616076756665dbda101f04
130514030212202122155d5e5f626364
3f402c0957071507505707016704036e
030c001000b8442c0080010203046dd8
5dc40178806b022878c33305e200cfe3
05c000e3060d01e20fffeb0146d00048
0a7e8660769400000000000000000000
000000000000000000000000000000f7
</edid_hex>
<supported_Video>
<video resolution="720x576i" Hz="50Hz" />
<video resolution="720x480p" Hz="60Hz" />
<video resolution="720x576p" Hz="50Hz" />
<video resolution="1280x720p" Hz="60Hz" />
<video resolution="1920x1080i" Hz="60Hz" />
<video resolution="1920x1080p" Hz="60Hz" />
<video resolution="1920x1080p" Hz="120Hz" />
<video resolution="1280x720p" Hz="50Hz" />
<video resolution="1920x1080i" Hz="50Hz" />
<video resolution="1920x1080p" Hz="30Hz" />
<video resolution="1920x1080p" Hz="50Hz" />
<video resolution="1920x1080p" Hz="25Hz" />
<video resolution="1920x1080p" Hz="24Hz" />
<video resolution="3840x2160p" Hz="30Hz" />
<video resolution="3840x2160p" Hz="25Hz" />
<video resolution="3840x2160p" Hz="24Hz" />
<video resolution="4096x2160p" Hz="24Hz" />
<video resolution="4096x2160p" Hz="25Hz" />
<video resolution="4096x2160p" Hz="30Hz" />
<video resolution="4096x2160p" Hz="50Hz" />
<video resolution="4096x2160p" Hz="60Hz" />
<video resolution="3840x2160p" Hz="50Hz" />
<video resolution="3840x2160p" Hz="60Hz" />
<video resolution="640x480p" Hz="60Hz" />
<video resolution="800x600p" Hz="60Hz" />
<video resolution="1024x768p" Hz="60Hz" />
<video resolution="1280x1024p" Hz="60Hz" />
</supported_Video>
<supported_420Video>
<video resolution="720x576p" Hz="50Hz" />
<video resolution="1280x720p" Hz="60Hz" />
<video resolution="1920x1080i" Hz="60Hz" />
<video resolution="1920x1080p" Hz="60Hz" />
<video resolution="1920x1080p" Hz="120Hz" />
<video resolution="1280x720p" Hz="50Hz" />
<video resolution="1920x1080i" Hz="50Hz" />
<video resolution="1920x1080p" Hz="30Hz" />
</supported_420Video>
<preferred_Video>
<video resolution="(null)" />
</preferred_Video>
<supported_Audio>
<audio codec="LPCM" ch="2" SamplingRate="32^44.1^48^96^192" />
<audio codec="AC3" ch="6" SamplingRate="32^44.1^48" />
<audio codec="DD+" ch="8" SamplingRate="32^44.1^48" />
<audio codec="Dolby TrueHD" ch="8" SamplingRate="48" />
</supported_Audio>
<supported_Color>
<color sampling="YCrCb 4:2:0" depth="6" />
<color sampling="YCrCb 4:2:0" depth="5" />
<color sampling="YCrCb 4:2:0" depth="4" />
<color sampling="YCrCb 4:4:4" depth="6" />
<color sampling="YCrCb 4:4:4" depth="5" />
<color sampling="YCrCb 4:4:4" depth="4" />
<color sampling="YCrCb 4:2:2" depth="6" />
<color sampling="YCrCb 4:2:2" depth="5" />
<color sampling="YCrCb 4:2:2" depth="4" />
<color sampling="RGB 4:4:4" depth="6" />
<color sampling="RGB 4:4:4" depth="5" />
<color sampling="RGB 4:4:4" depth="4" />
</supported_Color>
</hdmi_edid>
current_hdmi-edid.txt (3,384 bytes)   
current_amhdmitx0_edid.txt (1,000 bytes)    
BFX-AT100:/sys/class/amhdmitx/amhdmitx0 # cat edid
Rx Manufacturer Name: GSM
Rx Product Code: c0c8
Rx Serial Number: 01010101
Rx Product Name: LG
Manufacture Week: 1
Manufacture Year: 2022
Physcial size(cm): 160 x 90
EDID Version: 1.3
EDID block number: 0x1
blk0 chksum: 0x64
Source Physical Address[a.b.c.d]: 1.0.0.0
native Mode f1, VIC (native 97):
ColorDeepSupport b8
97 96 118 117 102 101 219 218 16 31 4 19 5 20 3 2 18 32 33 34 21 93 94 95 98 99 100 63 64 95 94 93 98 353 352 358 357
Audio {format, channel, freq, cce}
{1, 1, 57, 7}
{2, 5, 7, 50}
{10, 7, 7, 1}
{12, 7, 4, 3}
Speaker Allocation: 0
Vendor: 0xc03 ( HDMI device)
MaxTMDSClock1 340 MHz
Vendor2: 0xc45dd8
MaxTMDSClock2 600 MHz
ALLM: 1
vLatency:  Invalid/Unknown
aLatency:  Invalid/Unknown
i_vLatency:  Invalid/Unknown
i_aLatency:  Invalid/Unknown
ColorMetry: 0xc0
SCDC: 1
RR_Cap: 0
LTE_340M_Scramble: 0
  DolbyVision2  HDR  DeepColor
checkvalue: 0x64f70000
BFX-AT100:/sys/class/amhdmitx/amhdmitx0 #
current_amhdmitx0_edid.txt (1,000 bytes)   

(SW) Kerwin Chen

2022-12-28 09:21

developer   ~0011591

Hi YK,

The codes to generate hdmi-edid.xml is different from "Edid_ReceiverProductNameParse()".
It also use '\n' as delimitor to get string for each line of '/sys/class/amhdmitx/amhdmitx0/edid'.
To get correct model name in hdmi-edid.xml, we need to modify it.

Can you pass patch to us for testing ?

Thank you !

(ALTech) Younkwang Jung

2022-12-28 09:55

developer   ~0011593

Hi Kerwin

The patch is mentioned in the JIRA(BTFAML-1352) as a picture file

My test code is

jglory@alt-MINIPC-PN50:~/work/data/skb_source/BFX-AT100_5.3.4_DEV/common/drivers/amlogic/media/vout/hdmitx/hdmi_tx_20$ git diff hdmi_tx_edid.c
diff --git a/drivers/amlogic/media/vout/hdmitx/hdmi_tx_20/hdmi_tx_edid.c b/drivers/amlogic/media/vout/hdmitx/hdmi_tx_20/hdmi_tx_edid.c
index 8253b0a9bcc4..f19a621be93f 100644
--- a/drivers/amlogic/media/vout/hdmitx/hdmi_tx_20/hdmi_tx_edid.c
+++ b/drivers/amlogic/media/vout/hdmitx/hdmi_tx_20/hdmi_tx_edid.c
@@ -305,7 +305,7 @@ static void Edid_ReceiverProductNameParse(struct rx_cap *prxcap,
        int i = 0;
        /* some Display Product name end with 0x20, not 0x0a
         */
- while ((data[i] != 0x0a) && (data[i] != 0x20) && (i < 13)) {
+ while (/* (data[i] != 0x0a) && (data[i] != 0x20) &&*/ (i < 13)) {
                prxcap->ReceiverProductName[i] = data[i];
                i++;
        }

Thank you
YK.Jung
BTFAML-1352_TestPatch.PNG (38,878 bytes)   
BTFAML-1352_TestPatch.PNG (38,878 bytes)   

(SW) Kerwin Chen

2022-12-28 15:54

developer   ~0011602

Hi YK,

Please change codes as below in 'vendor/amlogic/common/frameworks/services/systemcontrol/HDCP/HDCPTxAuth.cpp'
============= ==================================================
...
                 else if(!strcmp(title,"Rx Product Name")){
- sscanf( lineBuf, "Rx Product Name: %s\n", edidHeader->prouctName);
+ sscanf( lineBuf, "Rx Product Name: %[^\n]", edidHeader->prouctName);
                 }
.....

(ALTech) Younkwang Jung

2023-02-06 15:52

developer   ~0012018

Hi Kerwin

Please apply this modification to ATV10 (BFX-AT100_5.3.6) / ATV12(BFX-AT100_5.3.7) for normal operation.

Thank you
YK.Jung

(SW) Kerwin Chen

2023-02-06 16:38

developer   ~0012022

Hi YK,

We will commit modification in EDID XML parsing.

How about the change in kernel driver ? (hdmi_tx_edid.c)
Does AML agree the change and they will commit to BitBucket ?

Thanks !

(ALTech) Younkwang Jung

2023-02-09 08:04

developer   ~0012073

HI Kerwin

AML says that each customized code for each TV manufacturer cannot be patched.
https://jira.skbroadband.com/browse/BTFAML-1352

Please commit the hdmi_tx_edid.c file as well.

Thanks!!
YK.Jung

Issue History

Date Modified Username Field Change
2022-12-27 12:21 (ALTech) Younkwang Jung New Issue
2022-12-27 12:21 (ALTech) Younkwang Jung Status new => assigned
2022-12-27 12:21 (ALTech) Younkwang Jung Assigned To => (SW) Kerwin Chen
2022-12-27 12:21 (ALTech) Younkwang Jung File Added: hdmi-edid_after_apply_test_patch.txt
2022-12-27 12:21 (ALTech) Younkwang Jung File Added: amhdmitx0_edid_after_apply_test_patch.txt
2022-12-27 12:21 (ALTech) Younkwang Jung File Added: current_hdmi-edid.txt
2022-12-27 12:21 (ALTech) Younkwang Jung File Added: current_amhdmitx0_edid.txt
2022-12-27 12:22 (ALTech) Younkwang Jung Description Updated View Revisions
2022-12-27 12:22 (ALTech) Younkwang Jung Issue Monitored: (ALTech) SY Yoon
2022-12-27 12:22 (ALTech) Younkwang Jung Issue Monitored: (ALTech) JunGyu Kim
2022-12-28 09:21 (SW) Kerwin Chen Note Added: 0011591
2022-12-28 09:55 (ALTech) Younkwang Jung Note Added: 0011593
2022-12-28 09:55 (ALTech) Younkwang Jung File Added: BTFAML-1352_TestPatch.PNG
2022-12-28 15:54 (SW) Kerwin Chen Note Added: 0011602
2022-12-28 15:55 (SW) Kerwin Chen Assigned To (SW) Kerwin Chen => (ALTech) Younkwang Jung
2022-12-28 15:55 (SW) Kerwin Chen Status assigned => acknowledged
2023-02-06 15:52 (ALTech) Younkwang Jung Note Added: 0012018
2023-02-06 16:38 (SW) Kerwin Chen Note Added: 0012022
2023-02-09 08:04 (ALTech) Younkwang Jung Note Added: 0012073
2024-04-19 14:12 (ALTech) Younkwang Jung Status acknowledged => closed
2024-04-19 14:12 (ALTech) Younkwang Jung Resolution open => fixed